Bug 1326138 has done some refactoring of autocomplete.xml. I'm current trying to get the no-undef rule enabled for eslint, and it has brought up to issues: /Users/mark/dev/gecko/toolkit/content/widgets/autocomplete.xml 2050:30 error 'item' is not defined. no-undef (eslint) 2053:14 error 'item' is not defined. no-undef (eslint) The blame points to bug 1326138. 'item' is not defined in autocomplete-richlistitem#_onChanged Additionally, I can't find any obvious callers of it - there's a call to `onChanged` but not `_onChanged`. Therefore, this looks like a mistake in the changes made.

(In reply to Mark Banner (:standard8) from comment #0) > Bug 1326138 has done some refactoring of autocomplete.xml. I'm current > trying to get the no-undef rule enabled for eslint, and it has brought up to > issues: > > /Users/mark/dev/gecko/toolkit/content/widgets/autocomplete.xml > 2050:30 error 'item' is not defined. no-undef (eslint) > 2053:14 error 'item' is not defined. no-undef (eslint) > > The blame points to bug 1326138. > > 'item' is not defined in autocomplete-richlistitem#_onChanged > > Additionally, I can't find any obvious callers of it - there's a call to > `onChanged` but not `_onChanged`. > > Therefore, this looks like a mistake in the changes made. Thanks Mark, It's a mistake I didn't notice while refactoring, I'll have a quick fix to this :-)

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=47e8ed4b81aad07adfb8b0dfac5a36d74e0ae50c

Comment on attachment 8839155 [details] Bug 1341019 - Fix undef item variable in _onChanged(). https://reviewboard.mozilla.org/r/113876/#review116660 I think Drew has been afk, so I'm going to steal this review to unblock the patch I would like to land ;-) This looks good to me and the changes make sense, it'd be nice to get this covered by a unit test at some stage, but I don't think that's critical for this patch to land.

Thank you Mark :) Rebased and updated reviewer. I'm afraid that I could not create a valid unit test in a short time, so let's land this patch first in order to not block your patch.

Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f7d197ff438e Fix undef item variable in _onChanged(). r=standard8